Thread (1 message) 1 message, 1 author, 2017-05-28

Re: [PATCH] doc: filter-branch does not require re-export of vars

From: Junio C Hamano <hidden>
Date: 2017-05-28 23:52:43

Jeff King [off-list ref] writes:
On Fri, May 26, 2017 at 07:36:54PM +0200, Andreas Heiduk wrote:
quoted
The function `set_ident` in `filter-branch` exported the variables
GIT_(AUTHOR|COMMITTER)_(NAME|EMAIL|DATE) at least since 6f6826c52b in 2007.
Therefore the filter scripts don't need to re-eport them again.
Some old shells keep separate values for the internal and exporter
versions of variables. I.e., this:

  foo=one
  export foo
  foo=two

would continue to export $foo as "one", even though it is "two" inside
the script.
Yup, that sounds like a grandfather's war story at this point,
though ;-)
However, I think POSIX mandates the behavior you'd expect. ...
...
At this point, I'd be inclined to remove the text as you suggest and
either make a small note at the bottom of the page, or just omit it
entirely and assume that anybody on an old non-POSIX shell can fend for
themselves.
Sounds good to me.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help