Thread (47 messages) 47 messages, 6 authors, 2017-06-05

Re: [GSoC][PATCH v5 3/3] submodule: port subcommand foreach from shell to C

From: Brandon Williams <hidden>
Date: 2017-05-27 01:48:54

On 05/26, Johannes Sixt wrote:
Am 26.05.2017 um 17:17 schrieb Prathamesh Chavan:
quoted
+	argv_array_pushf(&cp.env_array, "path=%s", list_item->name);
Not good! On Windows, environment variables are case insensitive.
The environment variable "path" has a very special purpose, although
it is generally spelled "PATH" (actually "Path" on Windows).

Lowercase "path" may have worked as long as it was only used in a
shell script (and perhaps only by lucky coincidence), but this I can
pretty much guarantee to fail. (I haven't tested it, though.)

The correct fix can only be to rename this variable here and in
shell scripts that need the value that is set here.

-- Hannes
Nice catch, the only reason why this would have worked before was
because it was a shell script before...

-- 
Brandon Williams
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help