Re: [PATCH v3 00/30] Easy to review grep & pre-PCRE changes
From: Junio C Hamano <hidden>
Date: 2017-05-20 23:50:34
From: Junio C Hamano <hidden>
Date: 2017-05-20 23:50:34
Ævar Arnfjörð Bjarmason [off-list ref] writes:
Easy to review? 29 (I mean 30) patches? Are you kidding me?! As noted in v1 ([ref]; https://public-inbox.org/git/20170511091829.5634-1-avarab@gmail.com/) these are all doc, test, refactoring etc. changes needed by the subsequent "PCRE v2, PCRE v1 JIT, log -P & fixes" series. Since Junio hasn't been picking it I'm no longer sending updates to that patch series & waiting for this one to cook first.
I actually do not mind a reroll that goes together with this. The only reason why I skipped the earlier one was because I looked at the original one, and the discussion on the reroll of this 'easy to review' part indicated that it will be rerolled, before I got to look at these upper layer patches. Overall nicely done. I only had just a few observations. Thanks.