Thread (2 messages) 2 messages, 2 authors, 2017-05-17

Re: t5545: reduced test coverage

flat view

From: Junio C Hamano <hidden>
Date: 2017-05-17 02:40:19

Possibly related (same subject, not in this thread)

Ramsay Jones [off-list ref] writes:
Hi Junio,

I noticed, when comparing the test-suite output from v2.12.0
versus v2.13.0-rc0 on cygwin, that t5545-push-options.sh was
no longer being run. (Well, now being skipped because it can't
find a web-server). Prior to commit 438fc68462 ("push options:
pass push options to the transport helper", 08-02-2017), this
test file ran three tests on 'local remotes'.

[I used to test with apache on Linux, but during an OS upgrade
(some time ago) I decided not to install apache just for the
git test-suite. (I used to run webgit and cgit, but no more!)]

I suppose it is not a major reduction in test coverage, but I
don't recall any discussion about it and I wondered if it was
by accident or design.

ATB,
Ramsay Jones
I think it was combination of carelessness and not caring about an
incomplete platform environment well enough.  

It appears to me that only a few tests in the entire script wants to
work with HTTP server, so perhaps moving them to the end, together
with the inclusion of lib-httpd and start_httpd that 438fc684 ("push
options: pass push options to the transport helper", 2017-02-08)
introduced, may be sufficient?

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help