Thread (29 messages) 29 messages, 9 authors, 2017-05-16

Re: git rebase regression: cannot pass a shell expression directly to --exec

flat view

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2017-05-16 20:27:47

On Tue, May 16, 2017 at 1:12 PM, Johannes Schindelin
[off-list ref] wrote:
quoted
I think it would be better to just

 (a) get rid of the magic strcspn() entirely

 (b) make the 'can we optimize this' test be simply just looking up
'argv[0]' in $PATH
What about

        ABC=1 my-executable my-arg
What about it?

Do you have a binary like

    '/usr/bin/ABC=1 my-executable my-arg'

or something? If so, it gets executed. If not, it would get passed off
to "/bin/sh".

That sounds a lot more obvious than "some random set of characters are magical".

                  Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help