Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit
From: Junio C Hamano <hidden>
Date: 2017-05-15 03:59:54
xiaoqiang zhao [off-list ref] writes:
Some email servers (e.g. smtp.163.com) limit the number emails to be sent per session(connection) and this will lead to a faliure when sending many messages. Teach send-email to disconnect after sending a number of messages (configurable via the --batch-size=<num> option), wait for a few seconds (configurable via the --relogin-delay=<seconds> option) and reconnect, to work around such a limit. Also add this two configure option for git config command.
s/configure/configuration/; "for git config command" is better left unsaid (too obvious).
Note: Re-authentication will happen every $<batch-size> messages, so it will be much more acceptable if you use some form of credential helper (e.g. the 'sendemail.smtppass' config option), otherwise you will have to retype password every time when asked.
I think this deserves to be in the end-user documentation (i.e. the part of your patch that updates Documentation/git-send-email.txt). Other than that, looking good ;-) Thanks.
Signed-off-by: xiaoqiang zhao <redacted> --- contrib/completion/git-completion.bash | 2 ++ git-send-email.perl | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+)