Thread (3 messages) 3 messages, 3 authors, 2017-05-11

Re: [PATCH 8/8] pathspec: convert parse_pathspec to take an index

flat view

From: Johannes Sixt <hidden>
Date: 2017-05-11 05:04:55

Am 11.05.2017 um 03:48 schrieb Junio C Hamano:
But perhaps you are right---it may be wrong for the contents of the
current index (or any index) to affect how a pathspec element is
parsed in the first place.  If the current code (before this series)
uses the_index only for error checking, we may want to separate that
out of the parse_pathspec() callchain, so that it does not even look
at any index (not just the_index).  And that may be a better change
overall.
Just a reminder: if core.ignoreCase is set, the variant of a path in the index takes precedence over the variant found in the working tree. Hence, pathspec must be matched against the index that corresponds to the working tree. I guess that's the_index.

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help