Thread (11 messages) 11 messages, 3 authors, 2017-05-10

Re: [PATCH v3 1/1] t0027: tests are not expensive; remove t0025

From: Torstem Bögershausen <hidden>
Date: 2017-05-10 19:55:27

Possibly related (same subject, not in this thread)

Ok for me, thanks for helping out.


Am 10.05.2017 um 17:52 schrieb Johannes Schindelin [off-list ref]:

Hi,
quoted
On Wed, 10 May 2017, tboegi@web.de wrote:

From: Torsten Bögershausen <redacted>

The purpose of t0027 is to test all CRLF related conversions at "git checkout"
and "git add".

Running t0027 under Git for Windows takes 3-4 minutes, so the whole script had
been marked as "EXPENSIVE".

The source code for "Git for Windows" overrides this since 2014:
"t0027 is marked expensive, but really, for MinGW we want to run these
tests always."

Recent "stress" tests show that t0025 if flaky, reported by Lars Schneider,
larsxschneider@gmail.com

All tests in t0025 are covered by t0027 already, so that t0025 can be retired.
t0027 takes less than 14 seconds under Linux, and 63 seconds under Mac Os X,
and this is more or less the same with a SSD or a spinning disk.

Acked-by: Johannes Schindelin <redacted>
Signed-off-by: Torsten Bögershausen <redacted>
This is still formatted very awkwardly. How about this instead (I fixed
the formatting, reworded a little here and there, and fixed the order of
the footers)?

-- snipsnap --
From: Torsten Bögershausen <redacted>

The purpose of t0027 is to test all CRLF related conversions at "git
checkout" and "git add".  Running t0027 under Git for Windows takes 3-4
minutes, so the whole script had been marked as "EXPENSIVE".

However, the "Git for Windows" fork overrides this since 2014: "t0027
is marked expensive, but really, for MinGW we want to run these tests
always."

The test seems not to be expensive on other platforms at all: it takes
less than 14 seconds under Linux, and 63 seconds under Mac Os X, and
this is more or less the same with a SSD or a spinning disk.

So let's drop the "EXPENSIVE" prereq.

While at it, retire t0025: Recent "stress" tests show that t0025 if
flaky, reported by Lars Schneider [off-list ref], but all
tests in t0025 are covered by t0027 already.

Signed-off-by: Torsten Bögershausen <redacted>
Acked-by: Johannes Schindelin <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help