Thread (1 message) 1 message, 1 author, 2017-05-09

Re: [PATCH v7] read-cache: force_verify_index_checksum

From: Junio C Hamano <hidden>
Date: 2017-05-09 02:11:28

Jeff Hostetler [off-list ref] writes:
On 5/8/2017 4:03 PM, Christian Couder wrote:
quoted
On Mon, May 8, 2017 at 6:50 PM, Jeff Hostetler [off-list ref] wrote:
quoted

On 5/8/2017 5:45 AM, Christian Couder wrote:
quoted
This test does not pass when the GIT_TEST_SPLIT_INDEX env variable is
set on my Linux machine.

Also it looks like you sent a v8 of this patch series with a different
test, but what is in master looks like the above test instead of the
test in your v8.
There was concern about using sed on a binary file not being portable
and a request to change the test to just corrupt the checksum rather
than an index-entry, so I changed it in v8.

Does the v8 version of the test also fail on your machine ?
The v8 version of the test succeeds on my machine.
OK, thanks.  It worked on mine too.  Since the v8 version is a
better test, I'm content to stick with it and not try to address
the problem with the previous version.
Thanks.  Let's merge that in.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help