Thread (1 message) 1 message, 1 author, 2017-05-08

Re: [PATCH 0/7] Update the compat/regex engine from upstream

From: Junio C Hamano <hidden>
Date: 2017-05-08 07:04:05

Ævar Arnfjörð Bjarmason [off-list ref] writes:
It's just to bring us in line with upstream which as noted in that
commit has fixed the issues we locally patched (and more), and for us
to stop maintaining a fork of an old version of part of Gawk.

There's no known issue with the existing engine that I'm aware of
which impacts git, but given ~7 years of bugfixes & improvements
there's surely something.
quoted
Having these "fixup!" as separate patches on the list makes them
smaller and easier to understand.  What do we want to do with them
once they are applied?  Squash them all up, because these do not
have their own explanations in their log message and it is not worth
keeping them separate?
Please squash them all up into this commit ("compat/regex: update the
gawk regex engine from upstream"), as noted having them as separate
patches was a hack to get around mailing list limits.

Also, un-squashed they'd break the NO_REGEX=Y build for a few commits,
which would be a pain during bisecting.
OK.  Thanks for clarification.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help