Thread (1 message) 1 message, 1 author, 2017-05-08

Re: [RESEND PATCH] diff: recurse into nested submodules for inline diff

From: Junio C Hamano <hidden>
Date: 2017-05-08 00:46:53

Jacob Keller [off-list ref] writes:
On Thu, May 4, 2017 at 2:43 PM, Stefan Beller [off-list ref] wrote:
quoted
When fd47ae6a5b (diff: teach diff to display submodule difference with an
inline diff, 2016-08-31) was introduced, we did not think of recursing
into nested submodules.

When showing the inline diff for submodules, automatically recurse
into nested submodules as well with inline submodule diffs.

Signed-off-by: Stefan Beller <redacted>
---

This is a resend of
https://public-inbox.org/git/20170331231733.11123-3-sbeller@google.com/

In the cover letter of that patch, I said I would want to redo the tests with
scrubbed output. However given the widespread use of unscrubbed output,
I think this is fine as-is to include.

Thanks,
Stefan
Fix looks obviously correct to me. I would like to change the tests to
not use the unscrubbed output, but that's a problem for a separate
patch.
OK.

Thanks, both.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help