Re: [PATCH v1 1/2] travis-ci: setup "prove cache" in "script" step
flat view
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2017-05-05 19:27:18
On Fri, May 5, 2017 at 5:40 PM, Lars Schneider [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The command that made the "prove cache" persistent across builds was executed in the "before_install" step. Consequently, every job that wanted to make use of the cache had to run this step. The "prove cache" is only used in the "script" step for the "make test" command. Therefore, we should configure the "prove cache" in this step. This change is useful for a subsequent patch that adds a job which does not need the "before_install" step but wants to run the "script" step to execute the tests. Signed-off-by: Lars Schneider <redacted> --- .travis.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)diff --git a/.travis.yml b/.travis.yml index 48cb00a581..aa03f8eb82 100644 --- a/.travis.yml +++ b/.travis.yml@@ -135,12 +135,14 @@ before_install: p4 -V | grep Rev.; echo "$(tput setaf 6)Git-LFS Version$(tput sgr0)"; git-lfs version; - mkdir -p $HOME/travis-cache; - ln -s $HOME/travis-cache/.prove t/.prove; before_script: make --jobs=2 -script: make --quiet test +script: + - > + mkdir -p $HOME/travis-cache; + ln -s $HOME/travis-cache/.prove t/.prove; + make --quiet test; after_failure: - >
This reminded me to submit a patch to prove itself to allow for customizing the location of the .prove file: https://github.com/Perl-Toolchain-Gang/Test-Harness/pull/66 Hopefully in the not too distant future we can then do away with this minor hack. Doesn't matter much to us, but just inflexible that such symlink hacks are needed.