Thread (13 messages) 13 messages, 2 authors, 2017-05-13

[PATCH v7 02/10] pkt-line: fix packet_read_line() to handle len < 0 errors

flat view
STALE3439d

From: Ben Peart <hidden>
Date: 2017-05-05 15:28:43
Subsystem: the rest · Maintainer: Linus Torvalds

Revision v7 of 8 in this series.

Revisions (8)
  1. v2 [diff vs current]
  2. v2 [diff vs current]
  3. v3 [diff vs current]
  4. v4 [diff vs current]
  5. v4 [diff vs current]
  6. v5 [diff vs current]
  7. v6 [diff vs current]
  8. v7 current
Update packet_read_line() to test for len > 0 to avoid potential bug
if read functions return lengths less than zero to indicate errors.

Signed-off-by: Ben Peart <redacted>
Found/Fixed-by: Lars Schneider [off-list ref]
---
 pkt-line.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkt-line.c b/pkt-line.c
index d4b6bfe076..6f05b1a4a8 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -315,7 +315,7 @@ static char *packet_read_line_generic(int fd,
 			      PACKET_READ_CHOMP_NEWLINE);
 	if (dst_len)
 		*dst_len = len;
-	return len ? packet_buffer : NULL;
+	return (len > 0) ? packet_buffer : NULL;
 }
 
 char *packet_read_line(int fd, int *len_p)
-- 
2.12.2.gvfs.2.20.g3624a68d62.dirty
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help