On Fri, Apr 28, 2017 at 03:20:21PM -0400, Devin Lehmacher wrote:

quoted

quoted

Test Summary Report
-------------------
t0301-credential-cache.sh                        (Wstat: 256 Tests: 29 Failed: 6)
  Failed tests:  12, 24-28
  Non-zero exit status: 1

Confirmed I'm seeing this on v2.13.0-rc1, and this passed in v2.12.2.
`git bisect` tells me this failure was introduced by commit
v2.12.0-267-g612c49e94, added by Devin Lehmacher (added to the CC
list).

Can someone with cygwin check that `test -S` works on cygwin?

Seems to work for me, using both Bash's built-in `test` and `/bin/test`:

    $ socat UNIX-LISTEN:socket-file LISTEN:socket-file &
    [1] 2976

    $ ls -l socket-file
    srw-r--r-- 1 add Domain Users 0 May  4 15:08 socket-file

    $ type test
    test is a shell builtin

    $ test -S socket-file && echo success
    success

    $ /bin/test -S socket-file && echo success
    success

    $ touch regular-file

    $ test -S regular-file && echo success

    $ /bin/test -S regular-file && echo success

    $ test -S non-existant-file && echo success

    $ /bin/test -S non-existant-file && echo success

I'll also take a look at verbose test output (maybe with a trace too)
for t0301 if someone sends me that.

The verbose t0301.12 output is below; the verbose test output from the other
failing tests is more-or-less identical.  I've attached the full trace
output, too: it looks like the fatal error below is on the `git
credential-cache exit` commands.

    fatal: read error from cache daemon: Connection reset by peer
    not ok 12 - socket defaults to ~/.cache/git/credential/socket
    #
    #               test_when_finished "
    #                       git credential-cache exit &&
    #                       rmdir -p .cache/git/credential/
    #               " &&
    #               test_path_is_missing "$HOME/.git-credential-cache" &&
    #               test -S "$HOME/.cache/git/credential/socket"
    #

This specific output came from v2.13.0-rc1 on an up-to-date 64-bit
Cygwin installation.  I'm happy to experiment with other build options /
patches / environments / &c. if that would be useful.

Adam