Re: [PATCH v2 03/53] Convert struct cache_tree to use struct object_id

[PATCH v2 00/53] object_id part 8 · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 01/53] fetch-pack: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 02/53] Clean up outstanding object_id transforms. · brian m. carlson <hidden> · 2017-05-01
Re: [PATCH v2 02/53] Clean up outstanding object_id transforms. · Brandon Williams <hidden> · 2017-05-02
Re: [PATCH v2 02/53] Clean up outstanding object_id transforms. · brian m. carlson <hidden> · 2017-05-03
[PATCH v2 03/53] Convert struct cache_tree to use struct object_id · brian m. carlson <hidden> · 2017-05-01
Re: [PATCH v2 03/53] Convert struct cache_tree to use struct object_id · Brandon Williams <hidden> · 2017-05-02
Re: [PATCH v2 03/53] Convert struct cache_tree to use struct object_id · brian m. carlson <hidden> · 2017-05-03
[PATCH v2 05/53] builtin/prune: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 04/53] builtin/name-rev: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 06/53] bundle: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 10/53] fast-import: convert internal structs to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 08/53] builtin/blame: convert static function to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 07/53] branch: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 12/53] submodule: convert merge_submodule to use struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 11/53] fast-import: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
Re: [PATCH v2 11/53] fast-import: convert to struct object_id · Jonathan Tan <hidden> · 2017-05-01
Re: [PATCH v2 11/53] fast-import: convert to struct object_id · Jeff King <hidden> · 2017-05-01
Re: [PATCH v2 11/53] fast-import: convert to struct object_id · Jonathan Tan <hidden> · 2017-05-01
Re: [PATCH v2 11/53] fast-import: convert to struct object_id · brian m. carlson <hidden> · 2017-05-03
[PATCH v2 14/53] parse-options-cb: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 13/53] notes-cache: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 16/53] builtin/verify-commit: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 09/53] builtin/rev-parse: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
Re: [PATCH v2 09/53] builtin/rev-parse: convert to struct object_id · Jonathan Tan <hidden> · 2017-05-01
[PATCH v2 15/53] reflog_expire: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 19/53] notes-utils: convert internals to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 21/53] shallow: convert shallow registration functions to object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 24/53] Convert remaining callers of lookup_commit_reference* to object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 22/53] sequencer: convert some functions to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 18/53] http-push: convert some static functions to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 23/53] builtin/tag: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 25/53] Convert lookup_commit* to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 26/53] pack: convert struct pack_idx_entry to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 17/53] tag: convert parse_tag_buffer to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 20/53] revision: convert prepare_show_merge to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 28/53] Convert remaining callers of lookup_blob to object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 30/53] tree: convert read_tree_1 to use struct object_id internally · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 27/53] builtin/unpack-objects: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 29/53] Convert lookup_blob to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 37/53] ref-filter: convert some static functions to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 35/53] Convert the verify_pack callback to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 38/53] refs: convert struct ref_update to use struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 36/53] Convert struct ref_array_item to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 40/53] http-push: convert process_ls_object and descendants to object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 39/53] refs/files-backend: convert many internals to struct object_id · brian m. carlson <hidden> · 2017-05-01
Re: [PATCH v2 39/53] refs/files-backend: convert many internals to struct object_id · Jonathan Tan <hidden> · 2017-05-01
Re: [PATCH v2 39/53] refs/files-backend: convert many internals to struct object_id · brian m. carlson <hidden> · 2017-05-03
[PATCH v2 33/53] log-tree: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 34/53] Convert lookup_tag to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 31/53] builtin/reflog: convert tree_is_complete to take struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 41/53] revision: rename add_pending_sha1 to add_pending_oid · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 32/53] Convert lookup_tree to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 42/53] revision: convert remaining parse_object callers to object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 43/53] upload-pack: convert remaining parse_object callers to object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 47/53] sequencer: convert fast_forward_to to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 49/53] builtin/ls-tree: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 51/53] sequencer: convert do_recursive_merge to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 45/53] builtin/read-tree: convert to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 44/53] sha1_name: convert internals of peel_onion to object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 46/53] builtin/ls-files: convert overlay_tree_on_cache to object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 52/53] tree: convert parse_tree_indirect to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 50/53] diff-lib: convert do_diff_cache to struct object_id · brian m. carlson <hidden> · 2017-05-01
[PATCH v2 53/53] object: convert parse_object* to take struct object_id · brian m. carlson <hidden> · 2017-05-01
Re: [PATCH v2 53/53] object: convert parse_object* to take struct object_id · Jonathan Tan <hidden> · 2017-05-01
[PATCH v2 48/53] merge: convert checkout_fast_forward to struct object_id · brian m. carlson <hidden> · 2017-05-01
Re: [PATCH v2 00/53] object_id part 8 · Stefan Beller <hidden> · 2017-05-01
Re: [PATCH v2 00/53] object_id part 8 · Brandon Williams <hidden> · 2017-05-02
Re: [PATCH v2 00/53] object_id part 8 · brian m. carlson <hidden> · 2017-05-04

From: brian m. carlson <hidden>
Date: 2017-05-03 23:36:52

On Tue, May 02, 2017 at 11:13:08AM -0700, Brandon Williams wrote:

Should this 20 be converted to GIT_{SHA1,MAX}_RAWSZ?  I know this is a
generated patch so maybe this is addressed, or will be addressed later?

Since this is a purely mechanical patch, I plan on addressing it later.
I'll probably do a search for 20s and 40s in the codebase as a future
series I work on.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204

Attachments

signature.asc [application/pgp-signature] 868 bytes

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help