Thread (2 messages) 2 messages, 2 authors, 2017-05-02

Re: [PATCH 2/5] submodule_move_head: prepare env for child correctly

flat view

From: Stefan Beller <hidden>
Date: 2017-05-02 04:19:01

On Mon, May 1, 2017 at 7:04 PM, Junio C Hamano [off-list ref] wrote:
Stefan Beller [off-list ref] writes:
quoted
We forgot to prepare the submodule env, which is only a problem for
nested submodules. See 2e5d6503bd (ls-files: fix recurse-submodules
with nested submodules, 2017-04-13) for further explanation.

Signed-off-by: Stefan Beller <redacted>
---
Sounds good (if only because this makes it similar to other
codepaths).

Is this something whose breakage before the patch is easily
demonstrated with a test?
I'll try to come up with a test in a reroll.

Thanks,
Stefan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help