Hi Phillip,

On Mon, 1 May 2017, Phillip Wood wrote:

On 28/04/17 20:22, Johannes Schindelin wrote:

quoted

BTW in the future you could help me a *lot* by providing a patch that
adds a test case to our test suite that not only demonstrates what
exactly goes wrong, but also will help prevent future regressions.

I'll bear that in mind, it does assume that reporters have a good
understanding of the test suite layout and helper functions though.

Even a shell script recreating the issue would be helpful, as it is easier
to turn such a reproducer into a test case than to write the test case
from scratch.

Is there a particular reason you put the test case in the autosquash
tests?  I wouldn't have thought of doing that.

Yes. I looked for existing test cases setting rebase.instructionFormat.
That's where I put the new one.

(I would also have avoided t3404, as it takes 5 minutes to run on Windows
due to its heavily-scripted nature: the shell script interpreter we use in
Git for Windows jumps through all kinds of hoops to emulate POSIX
functionality, and that costs time)

Ciao,
Johannes