Thread (30 messages) 30 messages, 5 authors, 2017-05-09

Re: [PATCH 1/2] Make the indent heuristic part of diff's basic configuration.

From: Jeff King <hidden>
Date: 2017-04-28 07:59:39

On Thu, Apr 27, 2017 at 04:50:36PM -0400, Marc Branchaud wrote:
Subject: [PATCH 1/2] Make the indent heuristic part of diff's basic configuration.

Signed-off-by: Marc Branchaud <redacted>
This needs to be explained better. Why were the options originally in
UI config, and why is it OK to move them to the basic config?

I think the argument is along the lines of "scripts shouldn't care
because the result is syntactically identical, and we reserve the right
to find any valid diff".

Also, our subject lines usually do not start with a capital, nor end
with a period. We usually try to specify the subsystem with a colon.
Like:

  diff: move indent heuristic to "basic" config

or similar.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help