Thread (1 message) 1 message, 1 author, 2017-04-24

Re: [PATCH 00/15] Handle fopen() errors

From: Junio C Hamano <hidden>
Date: 2017-04-24 00:45:13

Jeff King [off-list ref] writes:
On Fri, Apr 21, 2017 at 07:27:20PM +0700, Duy Nguyen wrote:
quoted
On Fri, Apr 21, 2017 at 6:52 PM, Junio C Hamano [off-list ref] wrote:
quoted
Yes, but (1) we'd need to be careful about --quiet
Yeah. It's a real pain point for making changes like this. At some
point we should just have a global (maybe multi-level) quiet flag.
I don't think it's too bad here. Isn't it just:

  FILE *fh = quiet ? fopen(x, y) : fopen_or_warn(x, y);

It is a little annoying to have to repeat "x", though (which is
sometimes a git_path() invocation).
Sure, but you could do

	fopen_or_warn(quiet, x, y)

if it is a problem ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help