Thread (7 messages) 7 messages, 3 authors, 2017-04-19

Re: [PATCH] various: disallow --no-no-OPT for --no-opt options

From: René Scharfe <hidden>
Date: 2017-04-19 13:44:52

Am 19.04.2017 um 15:19 schrieb Ævar Arnfjörð Bjarmason:
I mean a bug in my patch, i.e. I meant to remove --no-no-OPT in cases
of --no-OPT but also removed --OPT unintentionally, but anyway, let's
drop this one, Jacob's patch is better.
Ah, OK.

You also wondered why no tests complained.  Good question.  Would it 
make sense to test every option *and* its negation?  That would double 
the number of tests in order to check a parseopt feature.  Hmm, not 
sure.  More test coverage would be good, but I doubt we'd ever arrive at 
100% for this.

If you had converted --no-doubt in t/helper/test-parse-options.c to 
OPT_BOOL_NONEG instead of or in addition to adding the new flag --no-neg 
then you'd seen the effect in t0040.

René
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help