Re: [PATCH v2 10/20] ref-cache: introduce a new type, ref_cache

On 04/07/2017 01:32 PM, Duy Nguyen wrote:

On Fri, Mar 31, 2017 at 9:11 PM, Michael Haggerty [off-list ref] wrote:

quoted

+void free_ref_cache(struct ref_cache *cache)
+{
+       free_ref_entry(cache->root);
+       free(cache);
+}

free(NULL) is no-op (and safe). Maybe we should follow the same
pattern for free_ref_cache(). It's really up to you.

If I look at other `free_*()` functions in our codebase, it doesn't seem
that many of them handle NULL, and that feature wouldn't help the
callers of this function. So I think I'll leave it the way that it is.

Michael