Thread (4 messages) 4 messages, 3 authors, 2017-03-31

Re: Issue with 2.11.0 and GIT_EXEC_PATH with multiple entries

flat view

From: Nate Mueller <hidden>
Date: 2017-03-31 00:39:31

Got it.  Thanks!

On Thu, Mar 30, 2017 at 4:32 PM, Jeff King [off-list ref] wrote:
On Thu, Mar 30, 2017 at 04:00:41PM -0700, Nate Mueller wrote:
quoted
Really?  My config has been set this way for years and it's never
caused problems before.  I have subcommands in both of those
directories and all work.
Really. It did happen to work most of the time before (because most uses
involved just appending it to $PATH). But it was never intended to work
with multiple paths. The:

  . "$(git --exec-path)/git-sh-whatever"

advice has been advertised in the documentation for years. E.g., see
bd870878f (Documentation: don't assume git-sh-setup and git-parse-remote
are in PATH, 2008-06-29). So even if we wanted to relax the rules in our
scripts, it seems like a potential hazard for 3rd party scripts.

The recommended way is to just put your ~/.git-exec into your $PATH.

-Peff


-- 
Nate Mueller - Head of Engineering - RetailNext - 406-356-6283
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help