Re: [ANNOUNCE] Git for Windows 2.12.2

Forwarding to the lists, as my original message was rejected for html.

On Thu, Mar 30, 2017 at 3:44 PM, Andrew Witte [off-list ref] wrote:

Just updated back to git 2.12.2 and git-lfs 2.0.2 and everything worked
fine. Wish I could have gotten more info when it happened as its happened on
a different computer as well. Will keep an eye out.

Also another note that I really don't like with Windows for Git since 2.12
is that It packages git-lfs with it. When I use the cmd it overrides the
other git-lfs install I have. I have to manually go and remove the old
git-lfs file in "program files" for things to work correctly.

On top of this git-lfs needs to be registered in the environment vars
because this is what the main git-lfs install does and apps Iv'e made like
Git-It-GUI (https://github.com/reignstudios/Git-It-GUI) invoke git-lfs
directly for some stuff. Because of this issue, the app will think a newer
version is installed thats different from what the normal git cmd reports.
Also doing git clone outside of the windows cmd with only git for windows
installed doesn't invoke git-lfs correctly as its not registered in the
system environment vars.  In short I don't think it should be shipped with
the installer as it just creates confusion.

On Thu, Mar 30, 2017 at 8:41 AM, Michael Rappazzo [off-list ref]
wrote:

quoted

I suspect that this is a problem in the windows credential manager.  I
tried this on:
  - git 2.12.2.windows.1 => failure
  - git 2.12.1.windows.1 => success

More Details:
I have a perl script which uses (a copy of Git.pm) to invoke the
credential manager.  While debugging that script, I dumped the hash that I
read from the credential manager:

    $git->credential($cred, 'fill');
    print Data::Dumper->Dump( [ $cred ] , [ "cred" ] );

In 2.12.2, this produces output like this:

    $cred = {
      'path' => '',
      'protocol' => 'https',
      'username' => '',
      'host' => 'some.host.com',
      'password' => ''
    };

In 2.12.1, this produces output like this:

    $cred = {
      'path' => '',
      'host' => 'some.host.com',
      'protocol' => 'https',
      'password' => 'my.password',
      'username' => 'mrappazzo'
    };

While debugging this, I did something to get it to work on 2.12.2.  After
downgrading to 2.12.1, I manually removed the credentials from Credential
Manager (in Control Panel).  After successful authentication, they were back
in the credential manager.  I then upgraded to 2.12.2, and I was able to
successfully authenticate.

To try to recreate the problem scenario again (in 2.12.2), I cleared the
credentials in Credential Manager.  Reattempting to authenticate gave the
credentials prompt.  The output of the perl hash was missing the password
again (thus, reproducing the error condition).

I hope this helps.
_Mike


On Wednesday, March 29, 2017 at 10:06:03 PM UTC-4, Andrew Witte wrote:

quoted

I'll try to get more info tomorrow.


On Wednesday, March 29, 2017 at 2:59:10 PM UTC-7, Johannes Schindelin
wrote:

quoted

Hi Andrew,

On Wed, 29 Mar 2017, Andrew Witte wrote:

quoted

The git 2.12 GCM for Windows is broken. I tried doing a git clone and
got "*remote: HTTP Basic: Access denied*".
I downgraded to git 2.11.0 and everything worked fine.

Could you test v2.12.1, too, and open a bug report at:
https://github.com/git-for-windows/git/issues/new ?

I am particularly interested in any details you can share that would
help
other developers like me to reproduce the issue.

Thank you,
Johannes