Re: [PATCH v5 0/6] [GSoC] remove_subtree(): reimplement using iterators

On 03/30/2017 05:32 AM, Daniel Ferreira wrote:

This is the fifth version of a patch series that implements the GSoC
microproject of converting a recursive call to readdir() to use dir_iterator.

v1: https://public-inbox.org/git/CAGZ79kZwT-9mHTiOJ5CEjk2wDFkn6+NcogjX0=vjhsAh16ANYg@mail.gmail.com/T/#t
v2: https://public-inbox.org/git/CACsJy8Dxh-QPBBLfaFWPAWUsbA9GVXA7x+mXLjEvYKhk1zOpig@mail.gmail.com/T/#t
v3: https://public-inbox.org/git/CAGZ79kYtpmURSQWPumobA=e3JBFjKhWCdv_LPhKCd71ZRwMovA@mail.gmail.com/T/#t
v4: https://public-inbox.org/git/1490747533-89143-1-git-send-email-bnmvco@gmail.com/T/#e437a63e0c22c00c69b5d92977c9b438ed2b9fd3a

I would like to really thank Michael for the incredibly thorough review of
the last version of this series. I never expected anyone to give that
level of attention to this change, and it's really, really appreciated.

All of the points he addressed are fixed in this version. As always, more
feedback is greatly appreciated.

Thanks for the reroll. I have reviewed v5 and it's much improved
relative to v4. I'm very encouraged by your quick and constructive
responses and especially that you are sticking with it even though the
project is getting much, much more involved than a typical GSoC
microproject. Perseverance is a very important prerequisite to success
in the Git project.

Please pay attention to formatting trivia like the formatting of
multiline constants. It's boring to give the same feedback multiple
times [1].

It's common that nontrivial patch series have to go though many
iterations before being accepted, so don't get discouraged. Even
experienced developers sometimes get past v10! The important thing is
that every round gets better than the last, that we learn from the
experience together, and that you don't give up, and then it is almost
certain that it will converge eventually!

I can't speak for the GSoC mentors who will make the decision, but I
would expect that your taking on an ambitious project and sticking with
it will leave a good impression, even if you don't quite get your change
accepted by whatever deadline. So don't panic that you are ruining your
chances by picking an ambitious project; quite the opposite is more
likely to be the case.

Michael

[1] softwareswirl.blogspot.com/2014/03/my-secret-tip-for-gsoc-success.html