Thread (1 message) 1 message, 1 author, 2017-03-23

Re: [PATCH] refs.c: use skip_prefix() in prettify_refname()

From: Junio C Hamano <hidden>
Date: 2017-03-23 19:40:41

René Scharfe [off-list ref] writes:
quoted
I think René meant this:

     /* just for side effects */
     skip_prefix(name, "refs/heads/", &name) ||
     skip_prefix(name, "refs/tags/", &name) ||
     skip_prefix(name, "refs/remotes/", &name);

     return name;

which still short-sircuits, even though I do think it looks
strange; "correct but strange".
Yes.  At least to me it looks less strange than the same lines wrapped
in "if ... /* nothing */".
Yup, after looking at it again, it does not look so "strange" to me.
I probably should have said "unusual but correct", not "correct but
strange".
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help