Re: [PATCH v2 3/3] sequencer: allow the commit-msg hooks to run during a `reword`
From: Junio C Hamano <hidden>
Date: 2017-03-23 16:52:11
Johannes Schindelin [off-list ref] writes:
quoted hunk
@@ -996,6 +998,8 @@ static int do_pick_commit(enum todo_command command, struct commit *commit, if (res || command != TODO_REWORD) goto leave; flags |= EDIT_MSG | AMEND_MSG; + if (command == TODO_REWORD) + flags |= VERIFY_MSG;
Good. This looks even cleaner than what we discussed during the review of the previous round. After deciding not to return early, we set the default set of features in flags and then further add verify-msg in when needed. Much easier to understand.