Re: [PATCH/RFC 2/3] stash: make push -p -q --no-keep-index quiet

On Sun, Mar 19, 2017 at 08:23:50PM +0000, Thomas Gummerer wrote:

Currently when using "git stash push -p -q --no-keep-index", the -q flag
is not passed to the git reset which is executed when --no-keep-index is
also passed in.  This means that git stash is somewhat verbose in this
mode even when the -q flag is passed in.  This was always the case since
"git stash save -p" was introduced in dda1f2a5 ("Implement 'git stash
save --patch'", 2009-08-13).

Properly pass the -q flag on to git reset, to make "git stash push -p
-q" as quiet as it should be.

Yeah, this is an obvious bug-fix. Though given my earlier response to
Junio, I wonder if we should just be doing "reset -q" unconditionally
for most of these calls.

I guess this one does say more than just "HEAD is at..."; it mentions
the files that you _didn't_ pick. Though that now makes it inconsistent
with the pathspec case, especially if you do:

  git stash push -p --no-keep-index -- one

which will mention "two" as remaining with unstaged changes.

-Peff