Re: [PATCH v3 0/2] diff --no-index: support symlinks and pipes
From: Junio C Hamano <hidden>
Date: 2017-03-20 16:09:03
Dennis Kaarsemaker [off-list ref] writes:
On Sun, 2017-03-19 at 15:08 -0700, Junio C Hamano wrote: ...quoted
quoted
- A --derefence option was added and the default is no longer to dereference symlinks.I do agree that it makes sense to have --[no-]dereference options, but I do not think it was my feedback and suggestion to make it optional (not default) to dereference, so please do not blame me for that choice.Then I misinterpreted your message at http://public-inbox.org/git/xmqqk29yedkv.fsf@gitster.mtv.corp.google.com/ No blame inteded, my apologies for coming across as blaming.
s/blame/credit/ then. I do not too deeply care which one is the default, and if we were adding --no-index without any existing users today, I probably would suggest making it deref by default (i.e. to make "diff --no-index" match better what other peoples' diffs do), but that would be a behaviour change to existing users if done today, so I think what you did probably is a good thing. Thanks.