Thread (1 message) 1 message, 1 author, 2017-03-14

Re: [GSoC][PATCH/RFC v3 2/3] credential-cache: use XDG_CACHE_HOME for socket

From: Junio C Hamano <hidden>
Date: 2017-03-14 01:50:17

Devin Lehmacher [off-list ref] writes:
Signed-off-by: Devin Lehmacher <redacted>
Reviewed-by: Junio C Hamano, Jeff King
The last line is premature; neither of us reviewed this exact
version and haven't checked if all the issues we mentioned in the
previous review have been addressed.

+static char *get_socket_path(void) {
Compare ths line with how cmd_main() below is declared.  Notice
any difference?  We begin our functions like this:

	static char *get_socket_path(void)
	{
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help