Thread (5 messages) flat view 5 messages, 4 authors, 2017-03-03

Re: [PATCH 3/4] filter-branch: fix --prune-empty on parentless commits

From: Jacob Keller <hidden>
Date: 2017-03-02 23:38:01

On Thu, Mar 2, 2017 at 11:36 AM, Junio C Hamano [off-list ref] wrote:
"Devin J. Pohly" [off-list ref] writes:
quoted
I think your point is interesting too, though.  If a commit is also
TREESAME to its parent(s?) in the _pre-filtered_ branch, it seems
reasonable that someone might want to leave it in the filtered branch as
an empty commit while pruning empt*ied* commits.  I would imagine that
as another option (--prune-newly-empty?).
I was hoping to hear from others who may care about filter-branch to
comment on this topic to help me decide, but I haven't heard
anything, so here is my tentative thinking.

I am leaning to:

 * Take your series as-is, which would mean --prune-empty will
   change the behaviour to unconditionally lose the empty root.
This new behavior is how I expected prune-empty to behave, so seeing
that it did not already behave this way was surprising.

Thanks,
Jake
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help