Re: [PATCH 2/2] pretty: use fmt_output_email_subject()
From: René Scharfe <hidden>
Date: 2017-03-02 00:08:24
Am 01.03.2017 um 12:37 schrieb René Scharfe:
Add the email-style subject prefix (e.g. "Subject: [PATCH] ") directly when it's needed instead of letting log_write_email_headers() prepare it in a static buffer in advance. This simplifies storage ownership and code flow. Signed-off-by: Rene Scharfe <redacted> --- This slows down the last three tests in p4000 by ca. 3% for some reason, so we may want to only do the first part for now, which is performance neutral on my machine.
Update below.
quoted hunk ↗ jump to hunk
diff --git a/commit.h b/commit.h index 9c12abb911..459daef94a 100644 --- a/commit.h +++ b/commit.h@@ -142,21 +142,24 @@ static inline int cmit_fmt_is_mail(enum cmit_fmt fmt) return (fmt == CMIT_FMT_EMAIL || fmt == CMIT_FMT_MBOXRD); } +struct rev_info; /* in revision.h, it circularly uses enum cmit_fmt */ + struct pretty_print_context { /* * Callers should tweak these to change the behavior of pp_* functions. */ enum cmit_fmt fmt; int abbrev; - const char *subject; const char *after_subject; int preserve_subject; struct date_mode date_mode; unsigned date_mode_explicit:1; + unsigned print_email_subject:1;
Turning this into an int restores performance according to p4000. Didn't know that bitfields can be *that* expensive. René