Thread (83 messages) 83 messages, 2 authors, 2017-03-18

Re: [PATCH 10/10] submodule--helper clone: check for configured submodules using helper

From: Brandon Williams <hidden>
Date: 2017-02-27 18:40:24

On 02/23, Stefan Beller wrote:
On Thu, Feb 23, 2017 at 3:47 PM, Brandon Williams [off-list ref] wrote:
quoted
@@ -795,14 +794,11 @@ static int prepare_to_clone_next_submodule(const struct cache_entry *ce,
        }

        /*
-        * Looking up the url in .git/config.
+        * Check if the submodule has been initialized.
         * We must not fall back to .gitmodules as we only want
         * to process configured submodules.
This sentence "we must not ..." is also no longer accurate,
as we do exactly that when using sub->url instead of just url
below.
You're right, I'll fix that.

-- 
Brandon Williams
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help