Thread (8 messages) 8 messages, 3 authors, 2017-02-27

[PATCH 1/2] commit: be more precise when searching for headers

flat view
STALE3509d

From: René Scharfe <hidden>
Date: 2017-02-25 19:22:23
Subsystem: the rest · Maintainer: Linus Torvalds

Search for a space character only within the current line in
read_commit_extra_header_lines() instead of searching in the whole
buffer (and possibly beyond, if it's not NUL-terminated) and then
discarding any results after the end of the current line.

Signed-off-by: Rene Scharfe <redacted>
---
 commit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/commit.c b/commit.c
index 2cf85158b4..173c6d3818 100644
--- a/commit.c
+++ b/commit.c
@@ -1354,8 +1354,8 @@ static struct commit_extra_header *read_commit_extra_header_lines(
 		strbuf_reset(&buf);
 		it = NULL;
 
-		eof = strchr(line, ' ');
-		if (next <= eof)
+		eof = memchr(line, ' ', next - line);
+		if (!eof)
 			eof = next;
 
 		if (standard_header_field(line, eof - line) ||
-- 
2.12.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help