Thread (22 messages) flat view 22 messages, 5 authors, 2017-03-07
STALE3488d

Revision v5 of 4 in this series.

Revisions (4)
  1. v5 current
  2. v6 [diff vs current]
  3. v6 [diff vs current]
  4. v7 [diff vs current]

[PATCH v5 0/1] Conditional config include

From: Nguyễn Thái Ngọc Duy <hidden>
Date: 2017-02-23 12:31:19

Let's try this again. v4 and before can be found in the original
thread [1]. The remaining issues of v4 were

On Fri, Aug 19, 2016 at 8:54 PM, Jeff King [off-list ref] wrote:
On Sat, Aug 13, 2016 at 03:40:59PM +0700, Duy Nguyen wrote:
quoted
Ping..
There was some discussion after v4. I think the open issues are:

  - the commit message is rather terse (it should describe motivation,
    and can refer to the docs for the "how")
Fixed
  - the syntax might be more clear as:

       [include-if "gitdir:..."]

    or

       [include "gitdir-is:..."]
I'll go with include-if. It feels a bit awkward to add -is to every
new type of condition.
  - there is an open question of whether we would like to go this route,
    maintaining backwards compatibility syntactically (and thus having
    these includes quietly skipped in older versions), or introduce a
    breaking syntax that could be more convenient, like:

      [if-gitdir(...):section]
      conditional-but-no-include-necessary = true

    I do not have a strong opinion myself, though I had written the
    original [include] assuming syntactic compatibility, and I think it
    has worked out (e.g., you can manipulate include.path via "git
    config" just as you would any other key).
I'll go with the what we have done, at least it's proven not provoking
too bad effects. So no breaking syntax.

[1] http://public-inbox.org/git/20160714153311.2166-1-pclouds@gmail.com/

Nguyễn Thái Ngọc Duy (1):
  config: add conditional include

 Documentation/config.txt  |  54 +++++++++++++++++++++++++
 config.c                  | 100 ++++++++++++++++++++++++++++++++++++++++++++++
 t/t1305-config-include.sh |  56 ++++++++++++++++++++++++++
 3 files changed, 210 insertions(+)

-- 
2.11.0.157.gd943d85
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help