Re: [PATCH v5 6/6] stash: allow pathspecs in the no verb form
From: Thomas Gummerer <hidden>
Date: 2017-02-19 09:17:59
On 02/17, Jeff King wrote:
On Fri, Feb 17, 2017 at 10:41:41PM +0000, Thomas Gummerer wrote:quoted
Now that stash_push is used in the no verb form of stash, allow specifying the command line for this form as well. Always use -- to disambiguate pathspecs from other non-option arguments.I think that makes sense.quoted
Also make git stash -p an alias for git stash push -p. This allows users to use git stash -p <pathspec>.And I think of all the options we discussed for handling "-p", I think this one makes the most sense. It may be worth calling out in the documentation that this is how it works though, so people do not think that: git stash -k -p <path> would work ("git stash -k -p" _does_ happen to work due to the old options-only rule, but I think we should advertise the general form as "-p is an alias for "push -p").
Yeah, I think adding something about this in the documentation would be good. I'll add a paragraph about this in the re-roll.
-Peff