Re: [PATCH 1/3] delete_refs(): accept a reflog message argument
From: Jeff King <hidden>
Date: 2017-02-17 08:12:13
On Thu, Feb 16, 2017 at 10:57:58PM -0500, Kyle Meyer wrote:
When the current branch is renamed with 'git branch -m/-M' or deleted with 'git update-ref -m<msg> -d', the event is recorded in HEAD's log with an empty message. In preparation for adding a more meaningful message to HEAD's log in these cases, update delete_ref() to take a message argument and pass it along to ref_transaction_delete(). Modify all callers to pass NULL for the new message argument; no change in behavior is intended.
Seems like a good first step.
quoted hunk ↗ jump to hunk
diff --git a/refs.h b/refs.h index 9fbff90e7..81627a63d 100644 --- a/refs.h +++ b/refs.h@@ -277,7 +277,7 @@ int reflog_exists(const char *refname); * be NULL_SHA1. flags is passed through to ref_transaction_delete(). */ int delete_ref(const char *refname, const unsigned char *old_sha1, - unsigned int flags); + unsigned int flags, const char *msg);
Should the "msg" argument go at the beginning, to match update_ref()? -Peff