Thread (2 messages) flat view 2 messages, 2 authors, 2017-02-16

Re: [PATCH 1/4 v4] revision.c: do not update argv with unknown option

From: Siddharth Kannan <hidden>
Date: 2017-02-16 19:40:27

Hey Matthieu,

On 16 February 2017 at 23:52, Matthieu Moy [off-list ref] wrote:
Indeed, I misread the patch. The explanation could be a little bit more
"tired-reviewer-proof" by not using a past tone, perhaps

1. setup_revision, which is changed to ...
Oh, okay! Sorry about the confusion!

Yes, I used the past perfect tense to refer to changes that were made
in this particular patch!

I will change the message in the next version to something that's in
present tense.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/


-- 

Best Regards,

- Siddharth.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help