Thread (1 message) 1 message, 1 author, 2017-02-15

Re: Back quote typo in error messages (?)

From: Junio C Hamano <hidden>
Date: 2017-02-15 21:32:03

Jeff King [off-list ref] writes:
So I think what you are seeing is not wrong in the sense of being
unintended by the author of the message. But I do think that git mostly
uses matched double or single quotes in its error messages, and the
non-symmetric quotes are relatively rare. Running:

  git grep "\`.*'" -- '*.c' ':!compat'

shows that there are only a few `quoted' cases in the code base (there
are 27 matches, but many of those are false positives, and some are in
comments).
I did a simpler 

    $ git grep "\`%s'"

and saw "`git %s' is aliased to `%s'" from builtin/help.c and
"unknown option `%s'" from parse-options.c (and revision.c)

What Fabrizio saw is the one in parse-options.c, so even though the
number of strings in the code is small, they appear everywhere.

I agree that we should standardise them, and we should do so early
in a cycle, because these appear also in .po files.  It is too late
for this cycle, obviously.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help