Re: [PATCH v1] t7400: cleanup "submodule add clone shallow submodule" test
From: Junio C Hamano <hidden>
Date: 2017-02-15 18:39:54
Lars Schneider [off-list ref] writes:
The test creates a "super" directory that is not removed after the test finished. This directory is not used in any subsequent tests and should therefore be removed. Signed-off-by: Lars Schneider <redacted> --- I just noticed that my bug report test does not run properly without this patch: http://public-inbox.org/git/20170215111704.78320-1-larsxschneider@gmail.com/ @Junio: I think this patch should be applied regardless of the bug.
Without the other one, this is not strictly needed, but I agree that it is a good code hygiene to make sure each test cleans up after itself. Is this the only one that needs change in the script from that "hygiene" point of view, or are there others? An alternative that is also acceptable is to squash this one into the other patch.
quoted hunk
t/t7400-submodule-basic.sh | 1 + 1 file changed, 1 insertion(+)diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh index b77cce8e40..08df483280 100755 --- a/t/t7400-submodule-basic.sh +++ b/t/t7400-submodule-basic.sh@@ -1078,6 +1078,7 @@ test_expect_success 'submodule with UTF-8 name' ' ' test_expect_success 'submodule add clone shallow submodule' ' + test_when_finished "rm -rf super" && mkdir super && pwd=$(pwd) && (base-commit: 3b9e3c2cede15057af3ff8076c45ad5f33829436 -- 2.11.0