Re: [PATCH] mingw: make stderr unbuffered again

Johannes Sixt [off-list ref] writes:

Am 14.02.2017 um 15:47 schrieb Johannes Schindelin:

quoted

quoted

From my point of view, it is not crucial. The next Git for Windows version

will have it, of course, and Hannes is always running with his set of
patches, he can easily cherry-pick this one, too.

The patch fixes the problem for me here.

I am a bit hesitant to call it "not crucial": The symptom I observed
is certainly not a show stopper; but who knows where else it is
important that stderr goes to the terminal earlier than other
output. As it is a new regression, it should be included in the next
release.

I tend to agree with you on the "not crucial" bit.

I applied the patch with "Tested-by: Johannes Sixt [off-list ref]"
on top of 1d3f065e0e ("mingw: follow-up to "replace isatty() hack"",
2017-01-18), which was the tip of js/mingw-isatty topic that was
merged to both master and maint during this cycle.  Unless I hear
the "fix" turns out to be undesirable in the coming few days, let's
plan to merge it to 'master' by the final.

Thanks.