Re: [PATCH] completion: complete modified files for checkout with '--'
From: SZEDER Gábor <hidden>
Date: 2017-02-14 00:50:44
On Tue, Feb 14, 2017 at 12:33 AM, [off-list ref] wrote:
From: Cornelius Weig <redacted> The command line completion for git-checkout bails out when seeing '--' as an isolated argument. For git-checkout this signifies the start of a list of files which are to be checked out. Checkout of files makes only sense for modified files,
No, there is e.g. 'git checkout that-branch this-path', too.
quoted hunk ↗ jump to hunk
therefore completion can be a bit smarter: Instead of bailing out, offer modified files for completion. Signed-off-by: Cornelius Weig <redacted> --- contrib/completion/git-completion.bash | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 6c6e1c7..d6523fd 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash@@ -1059,7 +1059,10 @@ _git_bundle () _git_checkout () { - __git_has_doubledash && return + __git_has_doubledash && { + __git_complete_index_file "--modified" + return + } case "$cur" in --conflict=*) --2.10.2