Thread (5 messages) 5 messages, 3 authors, 2017-02-13

Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

From: Pranit Bauva <hidden>
Date: 2017-02-10 16:04:51

Hey Johannes,

On Fri, Feb 10, 2017 at 7:50 PM, Johannes Schindelin
[off-list ref] wrote:
It is curious that only MacOSX builds trigger an error about this, both
GCC and Clang, but not Linux GCC nor Clang (see
https://travis-ci.org/git/git/jobs/200182819#L1152 for details):

builtin/bisect--helper.c:299:6: error: variable 'good_syn' is used
                uninitialized whenever 'if' condition is true
                [-Werror,-Wsometimes-uninitialized]
        if (missing_good && !missing_bad && current_term &&
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
builtin/bisect--helper.c:350:7: note: uninitialized use occurs here
        if (!good_syn)
             ^~~~~~~~

If you "re-roll" (or, as pointed out at the Contributors' Summit, better
put: if you send another iteration of the patch series), please squash
this fix in.

Signed-off-by: Johannes Schindelin <redacted>
Thanks for making this fix! :) I will squash it in.

Regards,
Pranit Bauva
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help