Re: [PATCH] difftool: fix bug when printing usage

Johannes Schindelin [off-list ref] writes:

quoted

quoted

Likewise, this would become

	GIT_CEILING_DIRECTORIES="$PWD/not" \
	test_expect_code 129 git -C not/repo difftool -h >output &&
	grep ^usage: output

I agree with the intent, but the execution here is "Not quite".
test_expect_code being a shell function, it does not take the
"one-shot environment assignment for this single invocation," like
external commands do.

So now that we know what is wrong, can you please enlighten me about what
is right?

David's original is just fine, isn't it?