Re: [PATCH v3] parse-remote: remove reference to unused op_prep

Siddharth Kannan [off-list ref] writes:

Hey Pranit,
On Sun, Feb 05, 2017 at 02:45:46AM +0530, Pranit Bauva wrote:

quoted

Hey Siddharth,

On Sat, Feb 4, 2017 at 8:01 PM, Siddharth Kannan
[off-list ref] wrote:

quoted

The error_on_missing_default_upstream helper function learned to
take op_prep argument with 15a147e618 ("rebase: use @{upstream}
if no upstream specified", 2011-02-09), but as of 045fac5845
("i18n: git-parse-remote.sh: mark strings for translation",
 2016-04-19), the argument is no longer used.  Remove it.

Signed-off-by: Siddharth Kannan <redacted>

This looks good to me! Thanks :)

Regards,
Pranit Bauva

Should I send this patch with "To:" set to Junio and "Cc:" set to the
mailing list, as mentioend in the SubmittingPatches document?

Nah, I was watching the discussion from the sideline.  I'll pick it
up after doing one final read on the patch myself.

Thanks, both.