Re: [PATCH v3 5/5] stash: teach 'push' (and 'create') to honor pathspec

On Sun, Feb 05, 2017 at 11:09:14PM -0800, Junio C Hamano wrote:

quoted

@@ -99,6 +104,10 @@ create_stash () {
 	if test -z "$new_style"
 	then
 		stash_msg="$*"
+		while test $# != 0
+		do
+			shift
+		done
 	fi

The intent is correct, but I would probaly empty the "$@" not with
an iteration of shifts but with a single

	set x && shift

;-)

Perhaps it is not portable, but I think "set --" does the same thing and
is perhaps less obscure.

-Peff