Thread (3 messages) flat view 3 messages, 3 authors, 2017-02-02

RE: git commit results in many lstat()s

From: Gumbel, Matthew K <hidden>
Date: 2017-02-02 00:14:47

"Junio C Hamano <mailto:jch2355@gmail.com> writes:

"Gumbel, Matthew K" [off-list ref] writes:
quoted
Yes, I think that when the user passes --only flag to git-commit, then git does not
need to call refresh_cache() in prepare_index() in builtin/commit.c.

I may experiment with that. Do you see any downside or negative side-effects?
There may be other fallouts, but one that immediately comes to mind
is that it may break pre-commit hook.
If pre-commit hook exists, we can fall-back to original behavior and call
refresh_cache(). Many repos will not have pre-commit hook and can 
benefit from the speedup.

I'm testing such a change locally. Git test suite seems to be running for quite
a while. Do you know any way to run it in parallel or otherwise speed it
up?

Thanks,
Matt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help