Thread (1 message) 1 message, 1 author, 2017-02-01

Re: [PATCH] doc: add note about ignoring --no-create-reflog

From: Junio C Hamano <hidden>
Date: 2017-02-01 23:54:29

Jeff King [off-list ref] writes:
On Wed, Feb 01, 2017 at 03:27:09PM -0800, Junio C Hamano wrote:
quoted
I had the same trouble wording.  Another thing I noticed was that I
deliberately left it vague what "default" this does not override,
because it appears to me that those who do not set logallrefupdates
will get the compiled-in default and that is also not overriden.

IOW, "does not negate the setting of core.logallrefupdates" will
open us to reports "I do not have the configuration set, but I still
get reflog even when --no-create-reflog is given".

   The negated form `--no-create-reflog` currently does not negate
   the default; it overrides an earlier `--create-reflog`, though.

perhaps?
True. I thought the default was "off", and that we merely set the config
when initializing a repo. But looking again, it really is checking
is_bare_repository() at runtime.

I still think it is OK to mention, as the description of
core.logallrefupdates is where we document the behavior and the
defaults. So even with "I do not have it set", that is still the key to
find more information.
OK, let's take yours as the final and merge it down to 'next'
soonish.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help