Thread (4 messages) flat view 4 messages, 3 authors, 2017-01-31

Re: [PATCH] Completion: Add support for --submodule=diff

From: Jacob Keller <hidden>
Date: 2017-01-31 00:17:34

On Sun, Dec 4, 2016 at 6:41 AM,  [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Peter Law <redacted>

Teach git-completion.bash about the 'diff' option to 'git diff
--submodule=', which was added in Git 2.11.

Signed-off-by: Peter Law <redacted>
---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 21016bf8d..ab11e7371 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1206,7 +1206,7 @@ _git_describe ()

 __git_diff_algorithms="myers minimal patience histogram"

-__git_diff_submodule_formats="log short"
+__git_diff_submodule_formats="diff log short"

 __git_diff_common_options="--stat --numstat --shortstat --summary
                        --patch-with-stat --name-only --name-status --color
--
2.11.0
Yep, this looks good to me.

Thanks,
Jake
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help