Re: [PATCH v4] t/Makefile: add a rule to re-run previously-failed tests
From: Junio C Hamano <hidden>
Date: 2017-01-27 18:57:58
Johannes Schindelin [off-list ref] writes:
This patch automates the process of determining which tests failed previously and re-running them. ... Signed-off-by: Johannes Schindelin <redacted>
I stored both versions in files and compared them, and it seems the single word change in the proposed commit log message is the only difference. I would have written "Automate the process...", though. If you are resending, touching up to cover all points raised by a reviewer and doing nothing else, having "Reviewed-by: Jeff King [off-list ref]" would have been nicer. Will queue. Thanks.
quoted hunk
--- Published-As: https://github.com/dscho/git/releases/tag/failing-tests-v4 Fetch-It-Via: git fetch https://github.com/dscho/git failing-tests-v4 t/Makefile | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/t/Makefile b/t/Makefile index d613935f14..1bb06c36f2 100644 --- a/t/Makefile +++ b/t/Makefile@@ -35,6 +35,12 @@ all: $(DEFAULT_TEST_TARGET) test: pre-clean $(TEST_LINT) $(MAKE) aggregate-results-and-cleanup +failed: + @failed=$$(cd '$(TEST_RESULTS_DIRECTORY_SQ)' && \ + grep -l '^failed [1-9]' *.counts | \ + sed -n 's/\.counts$$/.sh/p') && \ + test -z "$$failed" || $(MAKE) $$failed + prove: pre-clean $(TEST_LINT) @echo "*** prove ***"; $(PROVE) --exec '$(SHELL_PATH_SQ)' $(GIT_PROVE_OPTS) $(T) :: $(GIT_TEST_OPTS) $(MAKE) clean-except-prove-cachebase-commit: 4e59582ff70d299f5a88449891e78d15b4b3fabe