Thread (13 messages) 13 messages, 3 authors, 2017-01-27

Re: [PATCH v2 1/1] reset: support the --stdin option

flat view

From: Johannes Schindelin <hidden>
Date: 2017-01-27 17:35:30

Hi Peff,

On Fri, 27 Jan 2017, Jeff King wrote:
On Fri, Jan 27, 2017 at 01:38:55PM +0100, Johannes Schindelin wrote:

A few minor suggestions:
quoted
+--stdin::
+	Instead of taking list of paths from the command line,
+	read list of paths from the standard input.  Paths are
+	separated by LF (i.e. one path per line) by default.
+
+-z::
+	Only meaningful with `--stdin`; paths are separated with
+	NUL character instead of LF.
Is it worth clarifying that these are paths, not pathspecs? The word
"paths" is used to refer to the pathspecs on the command-line elsewhere
in the document.

It might also be worth mentioning the quoting rules for the non-z case.
I think this would be overkill. In reality, --stdin without -z does not
make much sense, anyway.

If you feel strongly about it, I encourage you to submit a follow-up
patch.

The rest of your suggestions have been implemented in v3.

Ciao,
Johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help